Move mac release CI to hosted ARM runners #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
changed the title
goodlyrottenapple
approved these changes
Oct 27, 2023
rv-jenkins
pushed a commit
that referenced
this pull request
Oct 27, 2023
https://github.com/runtimeverification/k/actions/runs/6666463392/job/18118970281 is a release job that has failed because `wget` isn't installed on the M2 runner it ran on after the migration in #3764. The solution is to make sure we install it via Homebrew before the bottling job runs.
rv-jenkins
pushed a commit
that referenced
this pull request
Oct 30, 2023
This PR reverts a series of experimental changes I made last week to attempt a fix for the flakiness of the macOS Homebrew job; the required implementation turned out to be substantially trickier than I'd thought and so this PR undoes the changes in the interest of returning the release job to a better state. The PRs reverted are: * #3764 * #3766 * #3767 * #3768 Additionally, I have temporarily disabled the PL-tutorial tests on Intel macOS to avoid a common source of release flakiness. Future changes to the Homebrew code should review and adapt the changes made and reverted here.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves our macOS packaging and release workflow over to use our self-hosted runners, which will hopefully address the recurrent flakiness we've had due to resource exhaustion (#3705).
I have tested these changes by adapting the release workflow to run on PRs, confirming that an
arm64_venturabottle gets successfully built. I don't anticipate any changes to the orchestration logic being required, but I will keep an eye on the release that this PR generates just to make sure that it doesn't break the release worse than it already is. In that event, this PR can easily be reverted or hotfixed.