Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add assertions for router transform and batch outputs #2982

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

chandumlg
Copy link
Member

@chandumlg chandumlg commented Jan 8, 2024

What are the changes introduced in this PR?

add assertions for router transform and batch outputs

What is the related Linear task?

Resolves INT-375 INT-1298

Please explain the objectives of your changes below

Adding asserts to router transform and batching outputs.
https://linear.app/rudderstack/issue/INT-375/fix-the-batching-order-in-the-applicable-routertransform-destinations

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@chandumlg chandumlg requested review from a team and sivashanmukh as code owners January 8, 2024 23:19
Copy link
Contributor

coderabbitai bot commented Jan 8, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (724a4ac) 87.07% compared to head (9822374) 87.07%.

❗ Current head 9822374 differs from pull request most recent head 1ef71da. Consider uploading reports for the commit 1ef71da to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2982   +/-   ##
========================================
  Coverage    87.07%   87.07%           
========================================
  Files          530      530           
  Lines        28812    28812           
  Branches      6860     6860           
========================================
  Hits         25088    25088           
  Misses        3377     3377           
  Partials       347      347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chandumlg chandumlg changed the title chore: rt_batch_tests chore: add assertions for router transform and batch outputs Jan 9, 2024
@chandumlg chandumlg force-pushed the chore.rt_batch_tests branch from 579785b to bab0617 Compare January 9, 2024 20:08
test/testHelper.js Outdated Show resolved Hide resolved
@chandumlg chandumlg force-pushed the chore.rt_batch_tests branch 2 times, most recently from 371d916 to fac5f38 Compare January 11, 2024 23:48
krishna2020
krishna2020 previously approved these changes Jan 16, 2024
@koladilip
Copy link
Contributor

@chandumlg are you using a different formatter by any chance?

@chandumlg
Copy link
Member Author

@chandumlg are you using a different formatter by any chance?

Im using prettier only.

@chandumlg chandumlg force-pushed the chore.rt_batch_tests branch 2 times, most recently from cbb6a02 to efe00ca Compare January 22, 2024 01:34
@devops-github-rudderstack
Copy link
Contributor

@chandumlg chandumlg force-pushed the chore.rt_batch_tests branch from 990fb68 to 4221905 Compare January 22, 2024 12:44
@devops-github-rudderstack
Copy link
Contributor

1 similar comment
@devops-github-rudderstack
Copy link
Contributor

@devops-github-rudderstack
Copy link
Contributor

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chandumlg chandumlg merged commit de4e321 into develop Jan 23, 2024
12 checks passed
@chandumlg chandumlg deleted the chore.rt_batch_tests branch January 23, 2024 16:53
@chandumlg chandumlg restored the chore.rt_batch_tests branch January 23, 2024 16:53
@chandumlg chandumlg deleted the chore.rt_batch_tests branch January 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants