chore: add assertions for router transform and batch outputs (#2982)

rudderlabs · Jan 23, 2024 · de4e321 · de4e321
1 parent 724a4ac
commit de4e321
Show file tree

Hide file tree

Showing 144 changed files with 20,049 additions and 31,486 deletions.
diff --git a/test/__tests__/data/pinterest_tag_router_batch_output.json b/test/__tests__/data/pinterest_tag_router_batch_output.json
@@ -142,10 +142,12 @@
       },
       "metadata": [
         {
-          "jobId": 1
+          "jobId": 1,
+          "userId": "u1"
         },
         {
-          "jobId": 2
+          "jobId": 2,
+          "userId": "u1"
         }
       ],
       "batched": true,
@@ -329,13 +331,16 @@
       },
       "metadata": [
         {
-          "jobId": 3
+          "jobId": 3,
+          "userId": "u1"
         },
         {
-          "jobId": 4
+          "jobId": 4,
+          "userId": "u1"
         },
         {
-          "jobId": 6
+          "jobId": 6,
+          "userId": "u1"
         }
       ],
       "batched": true,
@@ -445,7 +450,8 @@
       },
       "metadata": [
         {
-          "jobId": 7
+          "jobId": 7,
+          "userId": "u1"
         }
       ],
       "batched": true,
@@ -496,7 +502,8 @@
     {
       "metadata": [
         {
-          "jobId": 5
+          "jobId": 5,
+          "userId": "u1"
         }
       ],
       "batched": false,
@@ -736,10 +743,12 @@
       },
       "metadata": [
         {
-          "jobId": 8
+          "jobId": 8,
+          "userId": "u1"
         },
         {
-          "jobId": 9
+          "jobId": 9,
+          "userId": "u1"
         }
       ],
       "statusCode": 200
@@ -852,7 +861,8 @@
       },
       "metadata": [
         {
-          "jobId": 10
+          "jobId": 10,
+          "userId": "u1"
         }
       ],
       "statusCode": 200

diff --git a/test/__tests__/data/pinterest_tag_router_error_input.json b/test/__tests__/data/pinterest_tag_router_error_input.json
@@ -75,7 +75,8 @@
       }
     },
     "metadata": {
-      "jobId": 5
+      "jobId": 5,
+      "userId": "u1"
     },
     "destination": {
       "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",

diff --git a/test/__tests__/data/pinterest_tag_router_error_output.json b/test/__tests__/data/pinterest_tag_router_error_output.json
@@ -2,7 +2,8 @@
   {
     "metadata": [
       {
-        "jobId": 5
+        "jobId": 5,
+        "userId": "u1"
       }
     ],
     "batched": false,

diff --git a/test/__tests__/data/pinterest_tag_router_input.json b/test/__tests__/data/pinterest_tag_router_input.json
@@ -77,7 +77,8 @@
         }
       },
       "metadata": {
-        "jobId": 1
+        "jobId": 1,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -198,7 +199,8 @@
         }
       },
       "metadata": {
-        "jobId": 2
+        "jobId": 2,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -300,7 +302,8 @@
         }
       },
       "metadata": {
-        "jobId": 3
+        "jobId": 3,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -421,7 +424,8 @@
         }
       },
       "metadata": {
-        "jobId": 4
+        "jobId": 4,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -542,7 +546,8 @@
         }
       },
       "metadata": {
-        "jobId": 5
+        "jobId": 5,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -663,7 +668,8 @@
         }
       },
       "metadata": {
-        "jobId": 6
+        "jobId": 6,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -764,7 +770,8 @@
         "files": {}
       },
       "metadata": {
-        "jobId": 7
+        "jobId": 7,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -888,7 +895,8 @@
         }
       },
       "metadata": {
-        "jobId": 8
+        "jobId": 8,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -1011,7 +1019,8 @@
         }
       },
       "metadata": {
-        "jobId": 9
+        "jobId": 9,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",
@@ -1134,7 +1143,8 @@
         }
       },
       "metadata": {
-        "jobId": 10
+        "jobId": 10,
+        "userId": "u1"
       },
       "destination": {
         "ID": "1pYpzzvcn7AQ2W9GGIAZSsN6Mfq",

diff --git a/test/__tests__/data/pinterest_tag_router_output.json b/test/__tests__/data/pinterest_tag_router_output.json
@@ -294,22 +294,28 @@
       },
       "metadata": [
         {
-          "jobId": 1
+          "jobId": 1,
+          "userId": "u1"
         },
         {
-          "jobId": 2
+          "jobId": 2,
+          "userId": "u1"
         },
         {
-          "jobId": 3
+          "jobId": 3,
+          "userId": "u1"
         },
         {
-          "jobId": 4
+          "jobId": 4,
+          "userId": "u1"
         },
         {
-          "jobId": 6
+          "jobId": 6,
+          "userId": "u1"
         },
         {
-          "jobId": 7
+          "jobId": 7,
+          "userId": "u1"
         }
       ],
       "batched": true,
@@ -360,7 +366,8 @@
     {
       "metadata": [
         {
-          "jobId": 5
+          "jobId": 5,
+          "userId": "u1"
         }
       ],
       "statTags": {
@@ -593,13 +600,16 @@
       },
       "metadata": [
         {
-          "jobId": 8
+          "jobId": 8,
+          "userId": "u1"
         },
         {
-          "jobId": 9
+          "jobId": 9,
+          "userId": "u1"
         },
         {
-          "jobId": 10
+          "jobId": 10,
+          "userId": "u1"
         }
       ],
       "batched": true,

diff --git a/test/__tests__/pinterestConversion.test.js b/test/__tests__/pinterestConversion.test.js
@@ -7,6 +7,8 @@ const path = require("path");
 const version = "v0";
 
 const transformer = require(`../../src/${version}/destinations/${integration}/transform`);
+const { assertRouterOutput } = require('../testHelper');
+
 const inputDataFile = fs.readFileSync(
   path.resolve(__dirname, `./data/${integration}_input.json`)
 );
@@ -44,6 +46,7 @@ describe(`${name} Tests`, () => {
     inputRouterData.forEach((input, index) => {
       it(`Payload: ${index}`, async () => {
         let output = await transformer.processRouterDest(input);
+        assertRouterOutput(output, input);
         expect(output).toEqual(expectedRouterData[index]);
       });
     });

diff --git a/test/__tests__/utilities/test-utils.js b/test/__tests__/utilities/test-utils.js
@@ -2,6 +2,7 @@ const fs = require("fs");
 const _ = require("lodash");
 const path = require("path");
 const { ConfigFactory, Executor } = require("rudder-transformer-cdk");
+const { assertRouterOutput } = require('../../testHelper');
 
 // TODO: separate this out later as the list grows
 const cdkEnabledDestinations = {
@@ -95,7 +96,9 @@ function executeTransformationTest(dest, transformAt) {
             if (transformAt == "processor") {
               actualData = await transformer.process(tcInput);
             } else {
-              actualData = (await transformer.processRouterDest([tcInput]))[0];
+              actual = await transformer.processRouterDest([tcInput])
+              assertRouterOutput(actual, [tcInput]);
+              actualData = (actual)[0];
             }
           }
           // Compare actual and expected data
@@ -115,6 +118,7 @@ function executeTransformationTest(dest, transformAt) {
           const version = "v0";
           const transformer = require(`../../../src/${version}/destinations/${dest}/transform`);
           actualData = await transformer.processRouterDest(commonInput);
+          assertRouterOutput(actualData, commonInput);
           const cloneActual = _.cloneDeep(actualData);
           cloneActual[0].statTags = "undefined";
           // Compare actual and expected data