Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hubspot max batch limit for contacts #2952

Merged
merged 18 commits into from
Jan 29, 2024
Merged

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Dec 26, 2023

What are the changes introduced in this PR?

This PR corrects the max batch limit for payload sent to hubspot as 100
Resolves INT-782

Please explain the objectives of your changes below

Our configuration in config.js file mentions the maxBatchSize of payload sent to hubspot as 10 but it is 100 as can be checked from Hubspot docs here.
Additionally we checked this with load testing with 50K and 200K Load and everything looks great and event the time taken decreased significantly

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Type of change

bug-fix

  • Existing capabilities/behaviour
    Previously data was sent to hubspot in a limit of upto 10 events per batch
  • New capabilities/behaviour
    Now data is sent to hubspot in a limit of upto 100 events per batch
    If the pull request is a new feature,

Any technical or performance related pointers to consider with the change?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.

N/A

If multiple linear tasks are associated with the PR changes, please elaborate on the reason:

N/A


Developer checklist

  • No breaking changes are being introduced.

  • Are all related docs linked with the PR?

  • Are all changes manually tested?

  • Does this change require any documentation changes?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@anantjain45823 anantjain45823 added DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH labels Dec 26, 2023
@anantjain45823 anantjain45823 self-assigned this Dec 26, 2023
@anantjain45823 anantjain45823 requested review from a team and sivashanmukh as code owners December 26, 2023 07:25
Copy link
Contributor

coderabbitai bot commented Dec 26, 2023

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@anantjain45823 anantjain45823 marked this pull request as draft December 26, 2023 08:50
@anantjain45823 anantjain45823 marked this pull request as ready for review December 26, 2023 08:50
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05172b4) 87.09% compared to head (ed33698) 87.09%.

Additional details and impacted files
@@               Coverage Diff                @@
##           hotfix/30012024    #2952   +/-   ##
================================================
  Coverage            87.09%   87.09%           
================================================
  Files                  530      530           
  Lines                28800    28800           
  Branches              6856     6856           
================================================
  Hits                 25084    25084           
  Misses                3371     3371           
  Partials               345      345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

@devops-github-rudderstack
Copy link
Contributor

1 similar comment
@devops-github-rudderstack
Copy link
Contributor

@anantjain45823 anantjain45823 changed the title chore: debug hubspot rate limitng fix: hubspot max batch limit for contacts Jan 25, 2024
@anantjain45823 anantjain45823 changed the base branch from develop to hotfix/30012024 January 25, 2024 15:09
@anantjain45823 anantjain45823 removed DO NOT MERGE Don't merge this PR without having discussion DO NOT TOUCH labels Jan 25, 2024
@devops-github-rudderstack
Copy link
Contributor

1 similar comment
@devops-github-rudderstack
Copy link
Contributor

Copy link

@anantjain45823 anantjain45823 merged commit bdeb641 into hotfix/30012024 Jan 29, 2024
15 checks passed
@anantjain45823 anantjain45823 deleted the fix.hs branch January 29, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants