-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hubspot max batch limit for contacts #2952
Conversation
Co-authored-by: Yashasvi Bajpai <[email protected]>
Co-authored-by: Yashasvi Bajpai <[email protected]>
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/30012024 #2952 +/- ##
================================================
Coverage 87.09% 87.09%
================================================
Files 530 530
Lines 28800 28800
Branches 6856 6856
================================================
Hits 25084 25084
Misses 3371 3371
Partials 345 345 ☔ View full report in Codecov by Sentry. |
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2952/test-report.html |
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2952/test-report.html |
1 similar comment
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2952/test-report.html |
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2952/test-report.html |
1 similar comment
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/2952/test-report.html |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What are the changes introduced in this PR?
This PR corrects the max batch limit for payload sent to hubspot as 100
Resolves INT-782
Please explain the objectives of your changes below
Our configuration in
config.js
file mentions the maxBatchSize of payload sent to hubspot as 10 but it is 100 as can be checked from Hubspot docs here.Additionally we checked this with load testing with 50K and 200K Load and everything looks great and event the time taken decreased significantly
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Type of change
bug-fix
Previously data was sent to hubspot in a limit of upto 10 events per batch
Now data is sent to hubspot in a limit of upto 100 events per batch
If the pull request is a new feature,
Any technical or performance related pointers to consider with the change?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
If the PR has changes in more than 10 files, please mention why the changes were not split into multiple PRs.
N/A
If multiple linear tasks are associated with the PR changes, please elaborate on the reason:
N/A
Developer checklist
No breaking changes are being introduced.
Are all related docs linked with the PR?
Are all changes manually tested?
Does this change require any documentation changes?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.