Skip to content

Commit

Permalink
fix: hubspot max batch limit for contacts (#2952)
Browse files Browse the repository at this point in the history
* feat: amplitude add support for unset

* Update src/v0/destinations/am/transform.js

Co-authored-by: Yashasvi Bajpai <[email protected]>

* Update src/v0/destinations/am/transform.js

Co-authored-by: Yashasvi Bajpai <[email protected]>

* chore:comment addresed

* Update transform.js

* chore:comment addresed

* chore: added docs

* chore: debug hubspot rate limitng issue

* Update prometheus.js

* Update transform.js

* Update util.js

* Update prometheus.js

* remove a space

---------

Co-authored-by: Yashasvi Bajpai <[email protected]>
  • Loading branch information
anantjain45823 and yashasvibajpai authored Jan 29, 2024
1 parent 05172b4 commit bdeb641
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/v0/destinations/hs/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const IDENTIFY_CRM_UPDATE_CONTACT = `${BASE_ENDPOINT}/crm/v3/objects/contacts/:c
const BATCH_IDENTIFY_CRM_CREATE_NEW_CONTACT = `${BASE_ENDPOINT}/crm/v3/objects/contacts/batch/create`;
const BATCH_IDENTIFY_CRM_UPDATE_CONTACT = `${BASE_ENDPOINT}/crm/v3/objects/contacts/batch/update`;
// Ref - https://developers.hubspot.com/docs/api/crm/contacts#endpoint?spec=GET-/crm/v3/objects/contacts
const MAX_BATCH_SIZE_CRM_CONTACT = 10;
const MAX_BATCH_SIZE_CRM_CONTACT = 100;

// Track
// Ref - https://developers.hubspot.com/docs/api/analytics/events
Expand Down
1 change: 1 addition & 0 deletions src/v0/destinations/hs/transform.js
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ const processRouterDest = async (inputs, reqMetadata) => {

try {
if (mappedToDestination && GENERIC_TRUE_VALUES.includes(mappedToDestination?.toString())) {
// retl
// skip splitting the batches to inserts and updates if object it is an association
if (objectType.toLowerCase() !== 'association') {
propertyMap = await getProperties(destination);
Expand Down

0 comments on commit bdeb641

Please sign in to comment.