Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard destination gaec to new UI #983

Merged
merged 8 commits into from
Nov 30, 2023
Merged

feat: onboard destination gaec to new UI #983

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3aef89a
feat: onboard gaec to new UI
ujjwal-ab Oct 15, 2023
0695ccf
Merge branch 'develop' into feat.gaec-newUI
ujjwal-ab Nov 8, 2023
4421ade
fix: update supportedMessageTypes & supportedConnectionModes as per n…
ujjwal-ab Nov 8, 2023
adb7b10
Merge branch 'develop' into feat.gaec-newUI
ujjwal-ab Nov 10, 2023
02bf2f8
Merge branch 'develop' into feat.gaec-newUI
ujjwal-ab Nov 13, 2023
33b948c
Merge branch 'develop' into feat.gaec-newUI
ujjwal-ab Nov 15, 2023
2602c57
Merge branch 'develop' into feat.gaec-newUI
ujjwal-ab Nov 28, 2023
14c61ed
Merge branch 'develop' into feat.gaec-newUI
ujjwal-ab Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/configurations/destinations/google_adwords_enhanced_conversions/db-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,18 @@
"saveDestinationResponse": true,
"includeKeys": ["oneTrustCookieCategories"],
"excludeKeys": [],
"supportedMessageTypes": ["track"],
"supportedConnectionModes": {
"web": ["cloud"],
"android": ["cloud"],
"ios": ["cloud"],
"unity": ["cloud"],
"amp": ["cloud"],
"reactnative": ["cloud"],
"flutter": ["cloud"],
"cordova": ["cloud"],
"shopify": ["cloud"]
},
"supportedMessageTypes": { "cloud": ["track"] },
"supportedSourceTypes": [
"android",
"ios",
Expand Down
218 changes: 143 additions & 75 deletions src/configurations/destinations/google_adwords_enhanced_conversions/ui-config.json
View file
Open in desktop
krishna2020 marked this conversation as resolved.
Show resolved Hide resolved
ujjwal-ab marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,78 +1,146 @@
{
"uiConfig": [
{
"title": "Connection Settings",
"fields": [
{
"type": "textInput",
"label": "Customer ID",
"value": "customerId",
"regex": "^(.{1,100})$",
"regexErrorMessage": "Invalid Customer Id",
"required": true,
"placeholder": "e.g: 9693429833"
},
{
"type": "checkbox",
"label": "Sub Account",
"value": "subAccount",
"required": false,
"default": false
},
{
"type": "textInput",
"label": "Login Customer ID",
"preRequisiteField": [{ "name": "subAccount", "selectedValue": true }],
"value": "loginCustomerId",
"regex": "^(.{1,100})$",
"required": true,
"footerNote": "If Customer-Id is from a sub account then provide customerId of manager account"
}
]
},
{
"title": "Event Settings",
"fields": [
{
"type": "dynamicCustomForm",
"value": "listOfConversions",
"label": "List of Conversion",
"customFields": [
{
"type": "textInput",
"value": "conversions",
"required": false,
"placeholder": "e.g: Credit Card Added"
}
]
},
{
"type": "checkbox",
"label": "Hashing required",
"value": "requireHash",
"default": true,
"footerNote": "If this option is set to on we will encrypt mail, phoneNumber, firstName, lastName and streetAddress"
}
]
},
{
"title": "Consent Settings",
"fields": [
{
"type": "dynamicCustomForm",
"value": "oneTrustCookieCategories",
"label": "OneTrust Cookie Categories",
"customFields": [
{
"type": "textInput",
"placeholder": "Marketing",
"value": "oneTrustCookieCategory",
"label": "Category Name/ID",
"required": false
}
]
}
]
"uiConfig": {
"baseTemplate": [
{
"title": "Initial setup",
"note": "Review how this destination is set up",
"sections": [
{
"groups": [
{
"title": "Connection Settings",
"note": "Update your connection settings here",
"icon": "settings",
"fields": [
{
"type": "textInput",
"label": "Customer ID",
"note": "Enter the Customer ID",
"configKey": "customerId",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$",
"regexErrorMessage": "Invalid Customer Id",
"placeholder": "e.g: 9693429833"
},
{
"type": "checkbox",
"label": "Sub Account",
"configKey": "subAccount",
"default": false
},
{
"type": "textInput",
"label": "Login Customer ID",
"note": "Enter the Login Customer ID",
"configKey": "loginCustomerId",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$",
"regexErrorMessage": "Invalid Login Customer Id",
"preRequisites": {
"fields": [
{
"configKey": "subAccount",
"value": true
}
]
}
}
]
}
]
},
{
"groups": [
{
"title": "Connection mode",
"note": [
"Update how you want to route events from your source to destination. ",
{
"text": "Get help deciding",
"link": "https://www.rudderstack.com/docs/destinations/rudderstack-connection-modes/"
}
],
"icon": "sliders",
"fields": []
}
]
}
]
},
{
"title": "Configuration settings",
"note": "Manage the settings for your destination",
"sections": [
{
"title": "Event settings",
"note": "Configure your event level settings",
"groups": [
{
"title": "Conversion settings",
"note": "Enter your list of Conversions",
"fields": [
{
"type": "tagInput",
"label": "List of Conversion",
"note": "Add your conversions names",
"configKey": "listOfConversions",
"tagKey": "conversions",
"placeholder": "e.g: Credit card visit",
"default": [
{
"conversions": ""
}
]
},
{
"type": "checkbox",
"label": "Hashing required",
"configKey": "requireHash",
"default": true,
"footerNote": "If this option is set to on we will encrypt mail, phoneNumber, firstName, lastName and streetAddress"
}
]
}
]
},
{
"title": "Other settings",
"note": "Configure advanced RudderStack features here",
"icon": "otherSettings",
"groups": [
{
"title": "OneTrust cookie consent settings",
"note": [
"Enter your OneTrust category names if you have them configured. ",
{
"text": "Learn more ",
"link": "https://www.rudderstack.com/docs/sources/event-streams/sdks/rudderstack-javascript-sdk/onetrust-consent-manager/"
},
"about RudderStack’s OneTrust Consent Manager feature."
],
"fields": [
{
"type": "tagInput",
"label": "Cookie category name",
"note": "Input your OneTrust category names by pressing ‘Enter’ after each entry",
"configKey": "oneTrustCookieCategories",
"tagKey": "oneTrustCookieCategory",
"placeholder": "e.g: Credit card visit",
"default": [
{
"oneTrustCookieCategory": ""
}
]
}
]
}
]
}
]
}
],
"sdkTemplate": {
"title": "Web SDK settings",
"note": "not visible in the ui",
"fields": []
}
]
}
}