-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard destination gaec to new UI #983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #983 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 78 78
Branches 13 13
=========================================
Hits 78 78 ☔ View full report in Codecov by Sentry. |
INT-826 Migrate one OAuth destination to new form builder
Scope: migration of destination + testing One of Google destinations |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
@ujjwal-ab can you attach screenshots of new UI layout in PR description ? |
src/configurations/destinations/google_adwords_enhanced_conversions/ui-config.json
Show resolved
Hide resolved
Added |
can we get OAuth module to the top as that would be logical first step to do ? And remove red * mark for Account, it's not used in new form builder |
Description of the change
Resolves INT-826
Checklists
Development
Code review