Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard destination gaec to new UI #983

Merged
merged 8 commits into from
Nov 30, 2023
Merged

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Oct 15, 2023

Description of the change

Resolves INT-826

  • Onboard Google Adwords Enhanced Conversions destination to new UI
image image

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7a91c8) 100.00% compared to head (14c61ed) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #983   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linear
Copy link

linear bot commented Oct 15, 2023

INT-826 Migrate one OAuth destination to new form builder

Scope: migration of destination + testing

One of Google destinations

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@ujjwal-ab ujjwal-ab removed the Stale label Nov 8, 2023
@krishna2020
Copy link
Collaborator

@ujjwal-ab can you attach screenshots of new UI layout in PR description ?

@ujjwal-ab
Copy link
Contributor Author

@ujjwal-ab can you attach screenshots of new UI layout in PR description ?

Added

@krishna2020
Copy link
Collaborator

@ujjwal-ab can you attach screenshots of new UI layout in PR description ?

Added

can we get OAuth module to the top as that would be logical first step to do ? And remove red * mark for Account, it's not used in new form builder

@ujjwal-ab ujjwal-ab merged commit 5f0aea5 into develop Nov 30, 2023
5 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the feat.gaec-newUI branch March 1, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants