Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing command arguments #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix missing command arguments #17

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c016045
add title and description support + do not override related_identifie…
fmigneault Nov 24, 2024
ad2f9eb
fix invalid format args
fmigneault Dec 3, 2024
83c17f1
Merge branch 'rseng:main' into main
fmigneault Dec 21, 2024
de4bcb4
pass down title/description to command
fmigneault Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,19 @@ runs:
ACTION_PATH: ${{ github.action_path }}
ZENODO_TOKEN: ${{ inputs.token }}
doi: ${{ inputs.doi }}
title: ${{ inputs.title }}
description: ${{ inputs.description }}
run: |
command="python ${{ github.action_path }}/scripts/deploy.py upload ${archive} --version ${version}"
if [[ "${doi}" != "" ]]; then
command="$command --doi ${doi}"
fi
if [[ "${title}" != "" ]]; then
command="$command --title ${title}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this likely to be more than one word and warrant quotes?

fi
if [[ "${description}" != "" ]]; then
command="$command --description ${description}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

fi
if [[ "${zenodo_json}" != "" ]]; then
command="$command --zenodo-json ${zenodo_json}"
fi
Expand Down