Fix missing command arguments #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good - I'll need to squash and merge. You might consider in the future doing PRs from a feature branch (and not main). What happens is that when commits are squashed and merged, all of your sudden your main branch will have commits that upstream does not, and they show up in PRs as they do here when they are in fact old commits. Generally speaking your main branch should always be in sync with upstream's main branch, so this is an erroneous state. |
vsoch
reviewed
Dec 21, 2024
| run: | | ||
| command="python ${{ github.action_path }}/scripts/deploy.py upload ${archive} --version ${version}" | ||
| if [[ "${doi}" != "" ]]; then | ||
| command="$command --doi ${doi}" | ||
| fi | ||
| if [[ "${title}" != "" ]]; then | ||
| command="$command --title ${title}" |
There was a problem hiding this comment.
Is this likely to be more than one word and warrant quotes?
| command="$command --title ${title}" | ||
| fi | ||
| if [[ "${description}" != "" ]]; then | ||
| command="$command --description ${description}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #16, adding the missing parameters to the commands so they are employed when called as action.