Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora 39 is EOL, long live Fedora 41 #43723

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 27, 2024

https://lists.fedoraproject.org/archives/list/[email protected]/thread/E7OANKIDHH2B6RHRKQHVKFOWAS23EQIH/

The number of invalid rules remained the same from Fedora 40 at 57.

Requires #43722

@cottsay cottsay added the rosdep Issue/PR is for a rosdep key label Nov 27, 2024
@cottsay cottsay self-assigned this Nov 27, 2024
@cottsay cottsay marked this pull request as ready for review November 27, 2024 21:35
@cottsay cottsay requested a review from a team as a code owner November 27, 2024 21:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ✅ Platforms for new rosdep rules are valid

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@cottsay
Copy link
Member Author

cottsay commented Nov 27, 2024

Interestingly, the Fedora rule for python3-segno is (and never has been) correct. It appears that the original PR (#35934) somehow bypassed the automated checks.

I'm going to remove the Fedora and RHEL rules for that key.

Aside: this is why positive confirmation via the new rosdistro-reviewer automation is important.

This package does not exist.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For changes related to rosdep:

  • ✅ Platforms for new rosdep rules are valid

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@cottsay cottsay merged commit 0d66d7f into ros:master Nov 28, 2024
5 checks passed
@cottsay cottsay deleted the cottsay/f39-eol branch November 28, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants