Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap CI for Ubuntu Jammy #2838

Closed
wants to merge 3 commits into from
Closed

Bootstrap CI for Ubuntu Jammy #2838

wants to merge 3 commits into from

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Mar 2, 2022

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2022

@ruffsl, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2022

@ruffsl, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@ruffsl ruffsl mentioned this pull request Mar 2, 2022
Closed
@SteveMacenski
Copy link
Member

Is this PR still relevant from #2852?

@mergify
Copy link
Contributor

mergify bot commented May 25, 2022

This pull request is in conflict. Could you fix it @ruffsl?

SteveMacenski
SteveMacenski reviewed May 25, 2022
View reviewed changes
nav2_system_tests/package.xml
@@ -48,7 +48,7 @@
<exec_depend>nav2_amcl</exec_depend>
<exec_depend>std_msgs</exec_depend>
<exec_depend>tf2_geometry_msgs</exec_depend>
<exec_depend>gazebo_ros_pkgs</exec_depend>
<!-- <exec_depend>gazebo_ros_pkgs</exec_depend> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we do require this, no?

@ruffsl
Copy link
Member Author

ruffsl commented May 25, 2022

Superseded by #2852

@ruffsl ruffsl closed this May 25, 2022
@ruffsl ruffsl deleted the ci_jammy branch May 25, 2022 15:12
@ruffsl ruffsl added the CI label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski left review comments

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruffsl @SteveMacenski