Rebased and updated version of PR145 (robot_status msg publishing) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Four spaces was used more frequently for indentation throughout the Rapid code. Tabs were converted to spaces and in a few places extra spaces were added or removed.
motion_possible depends on ctrlr state and state of ROS motion task. Only when motion task (not motion server!) is running can motions be executed.
Otherwise, set it to zero.
gavanderhoorn
force-pushed
the
update_pr145
branch
from
c54a411
to
7b2cd6c
Compare
|
Sigh GH<->Travis. |
|
Let's wait for Travis and then merge. |
|
And of course a review from someone else, as this is my own PR .. |
gavanderhoorn
requested review from
ipa-nhg,
jrgnicho,
Levi-Armstrong and
shaun-edwards
|
Note: this should not be squash-merged. |
gavanderhoorn
force-pushed
the
update_pr145
branch
from
7b2cd6c
to
ae0cc35
Compare
|
@ros-industrial/ros-i-reviewers: could any of you take a look here? |
|
I would like to get this in so we can push a new release of |
Levi-Armstrong
approved these changes
Jun 30, 2019
|
Thanks @Levi-Armstrong. Did you have "rebase and merge" selected? That should not have been necessary. |
|
And a big thanks to @keerthanamanivannan and @yamokosk for all the work on this PR. I only did some management and testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per subject.
All the hard work done by @yamokosk and @keerthanamanivannan in #145.