Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service call timeout argument in spawner (backport #1808) #1886

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 25, 2024

This PR exposes the call_timeout of the spawner to be optionally set by the user


This is an automatic backport of pull request #1808 done by Mergify.

Copy link
Contributor Author

mergify bot commented Nov 25, 2024

Cherry-pick of 41d7393 has failed:

On branch mergify/bp/humble/pr-1808
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 41d7393.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   controller_manager/controller_manager/spawner.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/controller_manager/controller_manager_services.py
	both modified:   controller_manager/doc/userdoc.rst
	both modified:   doc/release_notes.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 25, 2024
---------

Signed-off-by: Angsa Deployment Team <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Co-authored-by: Angsa Deployment Team <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.19%. Comparing base (d897740) to head (efb323a).
Report is 17 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1886      +/-   ##
==========================================
+ Coverage   62.58%   63.19%   +0.61%     
==========================================
  Files         108      109       +1     
  Lines       12026    12292     +266     
  Branches     8133     8310     +177     
==========================================
+ Hits         7526     7768     +242     
+ Misses        880      820      -60     
- Partials     3620     3704      +84     
Flag Coverage Δ
unittests 63.19% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller_manager/controller_manager_services.py 82.03% <100.00%> (+9.61%) ⬆️
controller_manager/controller_manager/spawner.py 69.40% <100.00%> (+0.35%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants