-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service call timeout argument in spawner #1808
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Angsa Deployment Team <[email protected]>
Signed-off-by: Angsa Deployment Team <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
+ Coverage 87.97% 88.01% +0.03%
==========================================
Files 121 121
Lines 12403 12404 +1
Branches 1105 1105
==========================================
+ Hits 10912 10917 +5
+ Misses 1085 1083 -2
+ Partials 406 404 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please rebase/merge on master and update the release_notes and docs as I've done in this PR.
Signed-off-by: Tony Najjar <[email protected]>
Done. I believe CI is failing not because of this PR |
Co-authored-by: Christoph Fröhlich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the follow-up!
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
I rebased to master and resolved conflicts caused by https://github.com/ros-controls/ros2_control/pull/1790/files. Could you please review @christophfroehlich @saikishor |
This PR exposes the call_timeout of the spawner to be optionally set by the user