Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service call timeout argument in spawner #1808

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

tonynajjar
Copy link
Contributor

This PR exposes the call_timeout of the spawner to be optionally set by the user

Angsa Deployment Team added 2 commits October 22, 2024 12:02
Signed-off-by: Angsa Deployment Team <[email protected]>
Signed-off-by: Angsa Deployment Team <[email protected]>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (23bd1c3) to head (a495547).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1808      +/-   ##
==========================================
+ Coverage   87.97%   88.01%   +0.03%     
==========================================
  Files         121      121              
  Lines       12403    12404       +1     
  Branches     1105     1105              
==========================================
+ Hits        10912    10917       +5     
+ Misses       1085     1083       -2     
+ Partials      406      404       -2     
Flag Coverage Δ
unittests 88.01% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller_manager/controller_manager_services.py 79.85% <100.00%> (+0.74%) ⬆️
controller_manager/controller_manager/spawner.py 72.65% <100.00%> (+0.43%) ⬆️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please rebase/merge on master and update the release_notes and docs as I've done in this PR.

@tonynajjar
Copy link
Contributor Author

tonynajjar commented Nov 6, 2024

LGTM, but please rebase/merge on master and update the release_notes and docs as I've done in this PR.

Done. I believe CI is failing not because of this PR

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the follow-up!

Signed-off-by: Tony Najjar <[email protected]>
@tonynajjar
Copy link
Contributor Author

I rebased to master and resolved conflicts caused by https://github.com/ros-controls/ros2_control/pull/1790/files. Could you please review @christophfroehlich @saikishor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants