-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Improve memory allocation with buffer variables #1801
base: master
Are you sure you want to change the base?
[CM] Improve memory allocation with buffer variables #1801
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
- Coverage 87.97% 87.95% -0.03%
==========================================
Files 121 121
Lines 12403 12385 -18
Branches 1105 1101 -4
==========================================
- Hits 10912 10893 -19
Misses 1085 1085
- Partials 406 407 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fair. Is there a reason that you went for a quite large number to reserve memory for?
Question: would using an RT-safe memory allocator not be a more scalable approach? |
This pull request is in conflict. Could you fix it @saikishor? |
Good question, the part of the vectors I can reduce it. For the part of the string, I think we will need it, when you have a large setup and it helps when concatenating strings |
@gavanderhoorn Sure, I wanted to keep it simple and isolated, so it's easier for others. No big reason apart from that. Let me know what you think |
d4e8050
to
40aa1a4
Compare
Do you have some pointers for us? (no pun intended! :D ) |
This PR tries to address the issue of memory allocation in the RT loop of the CM
read
,write
, andupdate
cycles