-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(emit-on-window-close): enable queries with EMIT ON WINDOW CLOSE
keyword
#9622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #9622 +/- ##
==========================================
+ Coverage 70.80% 70.82% +0.01%
==========================================
Files 1238 1238
Lines 207141 207367 +226
==========================================
+ Hits 146676 146873 +197
- Misses 60465 60494 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR
LogicalXxx::to_stream
to be aware ofEMIT ON WINDOW CLOSE
mode by adding a field toToStreamContext
. (Later in feat(over window): generate EOWC stream plan fromLogicalOverAgg
#9597 we will have our first operator that generates EOWC version of stream node for EOWC emit mode.)emit_on_window_close
field toPlanBase
so that every plan node has to decide whether it's EOWC.StreamSort
above the generated stream plan root when user required EOWC mode.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note
Support
EMIT ON WINDOW CLOSE
mode for queries on sources with watermark column.Example: