-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(over window): generate EOWC stream plan from LogicalOverAgg
#9597
Conversation
f2d92c4
to
5744289
Compare
LogicalOverAgg
LogicalOverAgg
c1b8d83
to
df3448c
Compare
5744289
to
11b4f17
Compare
Codecov Report
@@ Coverage Diff @@
## main #9597 +/- ##
==========================================
+ Coverage 70.83% 70.90% +0.07%
==========================================
Files 1238 1238
Lines 207367 207449 +82
==========================================
+ Hits 146879 147090 +211
+ Misses 60488 60359 -129
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -56,7 +56,8 @@ impl ExecutorBuilder for EowcOverWindowExecutorBuilder { | |||
.expect("vnodes not set for EOWC over window"), | |||
)); | |||
let state_table = | |||
StateTable::from_table_catalog(node.get_state_table()?, store, vnodes).await; | |||
StateTable::from_table_catalog_inconsistent_op(node.get_state_table()?, store, vnodes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yet another inconsistent op
Why not merge into the main branch? |
Because this PR depends on #9622. Will merge that first, then this PR will automatically based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ede66b0
to
5147f02
Compare
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
5147f02
to
29f4cad
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR enables Over Window feature with
EMIT ON WINDOW CLOSE
. Tracked in #9124.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Types of user-facing changes
Release note
Support Over Window (a.k.a Over Aggregation or Window Function) with
EMIT ON WINDOW CLOSE
. Currently only support windows partitioned by at least one column and ordered by only single watermark column.Example:
Window functions supported by far:
lag
andlead
with constant offsetWindow frame types supported by far:
ROWS
without exclusion clause