Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(telemetry): avoid backtrace in TrackingId::from_meta_store error #9059

Merged
merged 1 commit into from
Apr 11, 2023
Merged

refactor(telemetry): avoid backtrace in TrackingId::from_meta_store error #9059

merged 1 commit into from
Apr 11, 2023

Conversation

odysa
Copy link
Contributor

@odysa odysa commented Apr 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix this #9042

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@odysa odysa requested a review from xiangjinwu April 11, 2023 02:24
xiangjinwu
xiangjinwu approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@odysa odysa added this pull request to the merge queue Apr 11, 2023
Merged via the queue into risingwavelabs:main with commit 87f367b Apr 11, 2023
@odysa odysa deleted the fix/avoid-backtrace branch April 11, 2023 03:47
@odysa odysa mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjinwu xiangjinwu xiangjinwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odysa @xiangjinwu