Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(telemetry): avoid backtrace in TrackingId::from_meta_store error #9042

Closed
xiangjinwu opened this issue Apr 7, 2023 · 1 comment
Closed
Assignees
Labels
component/meta Meta related issue. difficulty/simple Issues that relatively easy and friendly to newcomers. type/enhancement Improvements to existing implementation.
Milestone

Comments

@xiangjinwu
Copy link
Contributor

Capturing a backtrace may segfault on Apple silicon #6205. We are still not able to find the root cause and fix it. In most cases, the issue would disappear after some random code change, usually in the next commit.

However, as another layer of safeguard, we should try to avoid capturing unnecessary backtrace, especially when the error is recoverable. This is the case for TrackingId::from_meta_store. The function can return an Option or a custom error type rather than anyhow::Error.

match Self::from_meta_store(meta_store).await {
Ok(id) => Ok(id),
Err(_) => {
let tracking_id = Self::new();
tracking_id.clone().put_at_meta_store(meta_store).await?;
Ok(tracking_id)
}
}

This has caused #9038, although it is not blocking the latest commit, as explained above.

@github-actions github-actions bot added this to the release-0.19 milestone Apr 7, 2023
@xiangjinwu xiangjinwu added component/meta Meta related issue. difficulty/simple Issues that relatively easy and friendly to newcomers. type/enhancement Improvements to existing implementation. and removed type/feature labels Apr 7, 2023
@odysa
Copy link
Contributor

odysa commented Apr 11, 2023

Closed since #9059 merged

@odysa odysa closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/meta Meta related issue. difficulty/simple Issues that relatively easy and friendly to newcomers. type/enhancement Improvements to existing implementation.
Projects
None yet
Development

No branches or pull requests

2 participants