feat(common): introduce JsonbVal as Scalar and JsonbRef as ScalarRef #7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7977 +/- ##
==========================================
- Coverage 71.45% 71.42% -0.04%
==========================================
Files 1118 1119 +1
Lines 180316 180399 +83
==========================================
- Hits 128849 128845 -4
- Misses 51467 51554 +87
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Feb 16, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
Part of the `jsonb` type support (preview all on [this branch](https://github.com/risingwavelabs/risingwave/compare/XJ-jsonb-WIP-2?expand=1)): * #7977 * Introduce `ArrayBuilder` and `Array` **(this PR)** * Introduce `DataType::Jsonb` * Add more expressions #7714 In this PR: * The in-memory layout of `JsonbArray` is simply a `Vec` or roots of json trees. This is easier to operate but do have space for optimization. * The protobuf layout is the same as `bytea` variable length array, with each element storing its value encoding. In case we switch to a newer protobuf layout, a new ArrayType enum value can be introduced without affecting parts other than `to_protobuf` and `from_protobuf`. * Refactored `VarSizedValueReader` from returning `RefItem` into accepting `&mut ArrayBuilder`. This is to use `JsonbArrayBuilder::append_move` on the deserialized `OwnedItem`. It is impossible to get a `JsonbArray::RefItem` from `&[u8]`. * Blanket implementation for `arrow` / `HashKeySerDe` / `RandValue`. Approved-By: BugenZhao
mergify bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
Part of the `jsonb` type support: * #7977 * #7986 * Introduce `DataType::Jsonb` **(this PR)** * Add more expressions #7714 In this PR: * Add `DataType::Jsonb`. * Support constructing it from string and displaying it as string. * Add e2e tests for `insert` and `select`. Also tested for the following but not added in CI: * prepared statement with BINARY format * kafka+json source with a `jsonb` field Approved-By: BugenZhao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Part of the
jsonbtype support (preview all on this branch):ScalarandScalarRef(this PR)ArrayBuilderandArrayDataType::Jsonbserde_jsonis chosen instead ofsimd_jsonfor the following reasons:postgres_types).BorrowedValue, it is notCopyand not suitable forJsonbRef.simd_jsonusesHashMapbutserde_jsondefaults toBTreeMap, which has a deterministic ordering and string representation.Checklist
- [ ] I have added necessary unit tests and integration tests(tested together in later part)./risedev check(or alias,./risedev c)Documentation