feat(common): introduce JsonbArrayBuilder and JsonbArray #7986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7986 +/- ##
==========================================
- Coverage 71.41% 71.38% -0.03%
==========================================
Files 1119 1119
Lines 180622 180760 +138
==========================================
+ Hits 128984 129033 +49
- Misses 51638 51727 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4 tasks
BugenZhao
approved these changes
Feb 17, 2023
| @@ -117,6 +117,12 @@ impl RandValue for bool { | |||
| } | |||
| } | |||
|
|
|||
| impl RandValue for JsonbVal { | |||
| fn rand_value<R: rand::Rng>(_rand: &mut R) -> Self { | |||
| JsonbVal::dummy() | |||
There was a problem hiding this comment.
Is this by design? What about adding a TODO here?
There was a problem hiding this comment.
List / Struct do not have this either. Opened #8001 for it.
mergify bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
Part of the `jsonb` type support: * #7977 * #7986 * Introduce `DataType::Jsonb` **(this PR)** * Add more expressions #7714 In this PR: * Add `DataType::Jsonb`. * Support constructing it from string and displaying it as string. * Add e2e tests for `insert` and `select`. Also tested for the following but not added in CI: * prepared statement with BINARY format * kafka+json source with a `jsonb` field Approved-By: BugenZhao
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Part of the
jsonbtype support (preview all on this branch):ArrayBuilderandArray(this PR)DataType::JsonbIn this PR:
JsonbArrayis simply aVecor roots of json trees. This is easier to operate but do have space for optimization.byteavariable length array, with each element storing its value encoding. In case we switch to a newer protobuf layout, a new ArrayType enum value can be introduced without affecting parts other thanto_protobufandfrom_protobuf.VarSizedValueReaderfrom returningRefIteminto accepting&mut ArrayBuilder. This is to useJsonbArrayBuilder::append_moveon the deserializedOwnedItem. It is impossible to get aJsonbArray::RefItemfrom&[u8].arrow/HashKeySerDe/RandValue.Checklist
- [ ] I have added necessary unit tests and integration tests(tested together in later part)./risedev check(or alias,./risedev c)Documentation