Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(expr): cleanup all RwErrors #4873

Merged
merged 7 commits into from
Aug 25, 2022
Merged

chore(expr): cleanup all RwErrors #4873

merged 7 commits into from
Aug 25, 2022

Conversation

BugenZhao
Copy link
Member

Signed-off-by: Bugen Zhao [email protected]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

@BugenZhao
Copy link
Member Author

May let #4862 merge first.

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #4873 (87908c8) into main (aa6aebd) will increase coverage by 0.13%.
The diff coverage is 80.51%.

@@            Coverage Diff             @@
##             main    #4873      +/-   ##
==========================================
+ Coverage   73.80%   73.93%   +0.13%     
==========================================
  Files         871      873       +2     
  Lines      131635   132637    +1002     
==========================================
+ Hits        97148    98066     +918     
- Misses      34487    34571      +84     
Flag Coverage Δ
rust 73.93% <80.51%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 72.30% <ø> (ø)
src/batch/src/rpc/service/task_service.rs 0.00% <0.00%> (ø)
src/cmd_all/src/playground.rs 0.00% <0.00%> (ø)
src/common/src/util/mod.rs 0.00% <ø> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/source/datagen/source/reader.rs 85.30% <ø> (-0.41%) ⬇️
src/expr/src/error.rs 25.00% <0.00%> (-15.00%) ⬇️
src/expr/src/expr/agg.rs 50.00% <0.00%> (ø)
src/expr/src/expr/expr_is_null.rs 90.21% <ø> (ø)
... and 98 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 61021b8 into main Aug 25, 2022
@mergify mergify bot deleted the bz/cleanup-rw-error-in-expr branch August 25, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants