Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch,agg): support array_agg for batch mode #4862

Merged
merged 10 commits into from
Aug 25, 2022
Merged

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 24, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR adds support for array_agg in batch mode.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#4657

stdrc added 5 commits August 24, 2022 18:47
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc added type/feature component/batch Batch related related issue. labels Aug 24, 2022
@stdrc stdrc requested review from BugenZhao and st1page August 24, 2022 12:08
Signed-off-by: Richard Chien <[email protected]>
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/expr/src/vector_op/agg/array_agg.rs Show resolved Hide resolved
Ok(())
}

fn output(&mut self, builder: &mut ArrayBuilderImpl) -> Result<()> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Are we still using RwResult for aggregators? 🥵

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened a PR for this: #4873

@BugenZhao BugenZhao mentioned this pull request Aug 25, 2022
3 tasks
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc mentioned this pull request Aug 25, 2022
3 tasks
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #4862 (82a2d30) into main (aa6aebd) will increase coverage by 0.08%.
The diff coverage is 79.23%.

@@            Coverage Diff             @@
##             main    #4862      +/-   ##
==========================================
+ Coverage   73.80%   73.88%   +0.08%     
==========================================
  Files         871      873       +2     
  Lines      131635   132547     +912     
==========================================
+ Hits        97148    97934     +786     
- Misses      34487    34613     +126     
Flag Coverage Δ
rust 73.88% <79.23%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/mod.rs 72.30% <ø> (ø)
src/batch/src/rpc/service/task_service.rs 0.00% <0.00%> (ø)
src/cmd_all/src/playground.rs 0.00% <0.00%> (ø)
src/common/src/util/mod.rs 0.00% <ø> (ø)
src/compute/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/source/datagen/source/reader.rs 85.30% <ø> (-0.41%) ⬇️
src/expr/src/expr/agg.rs 50.00% <ø> (ø)
src/expr/src/expr/expr_unary.rs 65.34% <0.00%> (-1.52%) ⬇️
src/expr/src/vector_op/agg/aggregator.rs 58.37% <0.00%> (-0.39%) ⬇️
... and 80 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 4f028d5 into main Aug 25, 2022
@mergify mergify bot deleted the rc/batch-array-agg branch August 25, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/batch Batch related related issue. type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants