Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): work around sea-orm bug #20099

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jan 10, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The SeaORM crate has a bug that causes the meta node to panic when using MySQL as the meta store. Specifically, the OnConflict do_nothing doesn't work for MySQL.

The bug has been fixed in SeaORM of newer version. This PR provides a workaround for the bug instead of upgrading the SeaORM version.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@zwang28 zwang28 enabled auto-merge January 10, 2025 12:38
@zwang28 zwang28 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into release-2.1 with commit 84e6fea Jan 10, 2025
30 of 31 checks passed
@zwang28 zwang28 deleted the wangzheng/workaround-seaorm branch January 10, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants