Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(meta): work around sea-orm bug for PG #20110

Merged
merged 1 commit into from
Jan 11, 2025
Merged

fix(meta): work around sea-orm bug for PG #20110

merged 1 commit into from
Jan 11, 2025

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jan 11, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The previous PR fixes the ORM issue for MySQL but break PG..

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@zwang28 zwang28 requested review from Li0k and lmatz January 11, 2025 06:13
@zwang28 zwang28 enabled auto-merge January 11, 2025 06:35
@zwang28 zwang28 requested review from hzxa21 and yezizp2012 and removed request for hzxa21 January 11, 2025 07:31
@zwang28 zwang28 added this pull request to the merge queue Jan 11, 2025
Merged via the queue into release-2.1 with commit 9e1cd76 Jan 11, 2025
28 of 29 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_orm branch January 11, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Li0k Li0k Li0k approved these changes

@yezizp2012 yezizp2012 yezizp2012 approved these changes

@lmatz lmatz Awaiting requested review from lmatz

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zwang28 @yezizp2012 @Li0k