-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: allow modification of the query mode #19424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I know why it was previously set to NO_ALTER_SYS
?
We've discussed offline and agreed NO_ALTER_SYS is not necessary. |
It seems our documentation and the runtime parameter system table do not differentiate if a parameter can be set globally or not at the moment. I thought all can be |
Co-authored-by: zwang28 <[email protected]>
Co-authored-by: zwang28 <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR permits to set the runtime parameter
query_mode
gloablly. Sometimes it's helpful to easily alter this parameter globally for queries sent from a client process, which otherwise need code change and rebuild for client process.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.