Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow modification of the query mode #19424

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Nov 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR permits to set the runtime parameter query_mode gloablly. Sometimes it's helpful to easily alter this parameter globally for queries sent from a client process, which otherwise need code change and rebuild for client process.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know why it was previously set to NO_ALTER_SYS?

@zwang28
Copy link
Contributor Author

zwang28 commented Nov 18, 2024

May I know why it was previously set to NO_ALTER_SYS?

We've discussed offline and agreed NO_ALTER_SYS is not necessary.

@yuhao-su

@lmatz
Copy link
Contributor

lmatz commented Nov 18, 2024

It seems our documentation and the runtime parameter system table do not differentiate if a parameter can be set globally or not at the moment. I thought all can be alter system set

@zwang28 zwang28 added this pull request to the merge queue Nov 19, 2024
@graphite-app graphite-app bot requested a review from a team November 19, 2024 09:20
Merged via the queue into main with commit 8f552d8 Nov 19, 2024
28 of 29 checks passed
@zwang28 zwang28 deleted the wangzheng/refactor_var branch November 19, 2024 10:01
@lmatz lmatz added the user-facing-changes Contains changes that are visible to users label Nov 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants