Skip to content

Commit

Permalink
refactor: allow modification of the query mode (#19424) (#19456)
Browse files Browse the repository at this point in the history
Co-authored-by: zwang28 <[email protected]>
  • Loading branch information
github-actions[bot] and zwang28 authored Nov 19, 2024
1 parent 5e618f4 commit 8696461
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions e2e_test/ddl/alter_session_params.slt
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ set STREAMING_ENABLE_DELTA_JOIN to false;
statement ok
set RW_STREAMING_ENABLE_DELTA_JOIN to true;

statement error session param query_mode cannot be altered system wide
alter system set query_mode to auto;

connection other1
query T
show RW_STREAMING_ENABLE_DELTA_JOIN;
Expand Down
2 changes: 1 addition & 1 deletion src/common/src/session_config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ pub struct SessionConfig {
/// The default value is auto which means let the system decide to run batch queries in local
/// or distributed mode automatically.
#[serde_as(as = "DisplayFromStr")]
#[parameter(default = QueryMode::default(), flags = "NO_ALTER_SYS")]
#[parameter(default = QueryMode::default())]
query_mode: QueryMode,

/// Sets the number of digits displayed for floating-point values.
Expand Down

0 comments on commit 8696461

Please sign in to comment.