Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agg): fix first_value and last_value to not ignore NULLs #19332

Merged
merged 5 commits into from
Nov 13, 2024

correct varchar generation in sqlsmith

155765d
Select commit
Loading
Failed to load commit list.
Merged

fix(agg): fix first_value and last_value to not ignore NULLs #19332

correct varchar generation in sqlsmith
155765d
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-11-13 04:03:45 ago

1 / 8 tasks completed

7 tasks still to be completed

Details

Required Tasks

Task Status
I have written necessary rustdoc comments Incomplete
I have added necessary unit tests and integration tests Incomplete
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Completed
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete
Fix the behavior of first_value and last_value in batch aggregate query and both batch & streaming window function query to align with PostgreSQL, so that they don't ignore NULL values. This may be a breaking change if you have streaming jobs containing first_value/last_value window function calls and there are NULL values before. Incomplete
#19332 Graphite 👈 Incomplete
main Incomplete
Nov 12, 11:03 PM EST: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite). Incomplete