fix(agg): fix first_value and last_value to not ignore NULLs
#19332
+98
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
stdrc
changed the title
first_value and last_value to not ignore NULLs
This was referenced Nov 11, 2024
xiangjinwu
approved these changes
Nov 11, 2024
stdrc
force-pushed
the
rc/fix-first-last-value-2
branch
from
cbd44a1 to
088edaa
Compare
stdrc
force-pushed
the
rc/fix-first-last-value-2
branch
from
088edaa to
8e9b078
Compare
kwannoel
reviewed
Nov 13, 2024
| if let Some(state) = &state.0 { | ||
| state.clone() | ||
| } else { | ||
| None |
There was a problem hiding this comment.
Can this lead to breaking changes? Since we ignore nulls previously.
There was a problem hiding this comment.
If so we need to include a release note.
stdrc
force-pushed
the
rc/fix-first-last-value-2
branch
from
8e9b078 to
7f5b7c7
Compare
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/fix-first-last-value-2
branch
from
7f5b7c7 to
155765d
Compare
Merge activity
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
) Signed-off-by: Richard Chien <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
) (#19365) Signed-off-by: Richard Chien <[email protected]> Co-authored-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
To align behavior with PG, we should not ignore NULLs when computing
first_valueandlast_value.This PR affects batch aggregate, batch over window. Also, a previous PR #19233 has already changed the behavior of streaming over window to the correct one.
Fixes #18927.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
first_valueandlast_valuein batch aggregate query and both batch & streaming window function query to align with PostgreSQL, so that they don't ignore NULL values. This may be a breaking change if you have streaming jobs containingfirst_value/last_valuewindow function calls and there are NULL values before.