Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): apply join transpose rule #19060

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Oct 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Fix the join transpose rule to handle join with output_indices. Previously, we used ProjectJoinSeparateRule in another stage to preprocess before applying ApplyProjectSetTransposeRule, but it turns out that some corner cases exist, so in this PR, we handle it inside ApplyProjectSetTransposeRule.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Oct 22, 2024
@chenzl25 chenzl25 requested review from fuyufjh and st1page October 22, 2024 17:05
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 586 to 587
- batch_plan
- stream_plan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the rule actually applies to the logical plan?

Copy link
Contributor Author

@chenzl25 chenzl25 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. it applies to the logical plan. Let me change it to optimized_logical_plan_for_batch.

@chenzl25 chenzl25 added need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 need-cherry-pick-release-2.1 labels Oct 23, 2024
@chenzl25 chenzl25 enabled auto-merge October 23, 2024 04:43
@chenzl25 chenzl25 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit fd975e0 Oct 23, 2024
29 of 30 checks passed
@chenzl25 chenzl25 deleted the dylan/fix_applt_join_transpose branch October 23, 2024 05:44
github-merge-queue bot pushed a commit that referenced this pull request Oct 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 need-cherry-pick-release-2.1 type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants