refactor(expr): separate user-facing rw_vnode from the internal one
#18815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/vnode-expr-batch
branch
from
67df70e to
5f948a0
Compare
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
commented
Oct 9, 2024
| @@ -261,7 +261,8 @@ impl ExprVisitor for ImpureAnalyzer { | |||
| | Type::MapContains | |||
| | Type::MapDelete | |||
| | Type::MapInsert | |||
| | Type::MapLength => | |||
| | Type::MapLength | |||
| | Type::VnodeUser => | |||
There was a problem hiding this comment.
VnodeUser should be deterministic.
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR separates the function type for the user-facing function
rw_vnode(..)(with typeVnodeUser, mainly for debugging purposes) from the internal one (with typeVnode, mainly for two-phase aggregation), while trying to reuse common code as much as possible.The difference between them is that, internal function
Vnodewill obtain the vnode count from the context (i.e. thevnode_countfield of the current fragment), while the user-facingVnodeUserwill use the first const argument for the vnode count.Can refer to e2e tests for its behavior.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.