refactor(storage): remove most usage of max_committed_epoch #18641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-wait-hummock-version
…max-committed-epoch
…d-max-committed-epoch
25 tasks
…d-max-committed-epoch
…d-max-committed-epoch
zwang28
approved these changes
Sep 27, 2024
| @@ -73,7 +73,7 @@ impl MetaSnapshotMetadata { | |||
| id, | |||
| hummock_version_id: v.id, | |||
| ssts: v.get_object_ids(), | |||
| max_committed_epoch: v.visible_table_committed_epoch(), | |||
| max_committed_epoch: v.max_committed_epoch_for_meta(), | |||
There was a problem hiding this comment.
The field max_committed_epoch can be removed too.
Unknown fields will be ignored when deserializing MetaSnapshotMetadata.
There was a problem hiding this comment.
The field will be deprecated in #18644
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Remove most usage of
max_committed_epoch. Previously, themax_committed_epochhas the semantic as the committed epoch of all visible tables. In this PR, all previous usage ofvisible_table_committed_epochis removed. Themax_committed_epochis only used meta node during recovery, to get the initial prev epoch after recovery. For this reason, themax_committed_epochis exposed only via methodmax_committed_epoch_for_meta.Notable changes in this PR:
version()method ofPinnedVersionis removed. Instead we useimpl Deref<Target = HummockVersion> for PinnedVersion.sstable_object_id_manager.ConflictDetectoris removed, which was not used previously.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.