feat(sink): support sink map to protobuf #18552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
xxchan
commented
Sep 17, 2024
Comment on lines
-492
to
-506
| let encoded: Vec<u8> = m.ser_to().unwrap(); | ||
| assert_eq!( | ||
| encoded, | ||
| // Hint: write the binary output to a file `test.binpb`, and view it with `protoc`: | ||
| // ``` | ||
| // protoc --decode_raw < test.binpb | ||
| // protoc --decode=all_types.AllTypes all-types.proto < test.binpb | ||
| // ``` | ||
| [ | ||
| 9, 0, 0, 0, 0, 0, 0, 17, 64, 21, 0, 0, 96, 64, 24, 22, 32, 23, 56, 48, 93, 26, 0, | ||
| 0, 0, 97, 27, 0, 0, 0, 0, 0, 0, 0, 104, 1, 114, 10, 82, 105, 115, 105, 110, 103, | ||
| 87, 97, 118, 101, 122, 2, 190, 239, 138, 1, 2, 8, 1, 146, 1, 3, 4, 0, 4, 186, 1, 3, | ||
| 16, 184, 23 | ||
| ] | ||
| ); |
There was a problem hiding this comment.
serialize map seems to be nondeterministic, so we can't test it in this way any more
xxchan
force-pushed
the
09-13-feat_sink_support_sink_map_type_in_encoder
branch
from
9dd684e to
20bc6e2
Compare
xxchan
force-pushed
the
09-17-feat_sink_support_sink_map_to_protobuf
branch
from
e25a617 to
ead2ebd
Compare
xxchan
force-pushed
the
09-13-feat_sink_support_sink_map_type_in_encoder
branch
from
20bc6e2 to
959ac33
Compare
xxchan
force-pushed
the
09-17-feat_sink_support_sink_map_to_protobuf
branch
from
ead2ebd to
3f3a678
Compare
xxchan
force-pushed
the
09-13-feat_sink_support_sink_map_type_in_encoder
branch
from
959ac33 to
8f1c089
Compare
xxchan
force-pushed
the
09-17-feat_sink_support_sink_map_to_protobuf
branch
from
3f3a678 to
15be669
Compare
xxchan
force-pushed
the
09-13-feat_sink_support_sink_map_type_in_encoder
branch
from
8f1c089 to
1739576
Compare
xxchan
force-pushed
the
09-17-feat_sink_support_sink_map_to_protobuf
branch
from
2cca4af to
fb8580d
Compare
Base automatically changed from
09-13-feat_sink_support_sink_map_type_in_encoder
to
main
September 19, 2024 14:57
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
09-17-feat_sink_support_sink_map_to_protobuf
branch
from
fb8580d to
dabf7e8
Compare
xxchan
added a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: xxchan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
…h release-2.0 (#18616) Signed-off-by: xxchan <[email protected]> Co-authored-by: Eric Fu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.