Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support sink map to avro #18551

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Sep 17, 2024

@xxchan xxchan changed the title avro feat(sink): support sink map to avro Sep 17, 2024
@xxchan xxchan marked this pull request as ready for review September 17, 2024 03:50
@xxchan xxchan force-pushed the 09-13-feat_sink_support_sink_map_type branch from ca90f22 to 80ec46d Compare September 17, 2024 05:41
@xxchan xxchan force-pushed the 09-13-feat_sink_support_sink_map_type_in_encoder branch 2 times, most recently from 20bc6e2 to 959ac33 Compare September 17, 2024 06:38
)
);

let mut inner_map_array_builder = MapArrayBuilder::with_type(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parsing nested map is not supported... so manually construct a test here...

@xxchan xxchan force-pushed the 09-13-feat_sink_support_sink_map_type_in_encoder branch from 959ac33 to 8f1c089 Compare September 17, 2024 06:52
@xxchan xxchan mentioned this pull request Sep 17, 2024
19 tasks
Base automatically changed from 09-13-feat_sink_support_sink_map_type to main September 17, 2024 07:47
@xxchan xxchan force-pushed the 09-13-feat_sink_support_sink_map_type_in_encoder branch from 8f1c089 to 1739576 Compare September 17, 2024 07:48
@graphite-app graphite-app bot requested a review from a team September 17, 2024 08:05
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, What's the purpose of impl MaybeData for () ?

@xxchan
Copy link
Member Author

xxchan commented Sep 19, 2024

What's the purpose of impl MaybeData for () ?

@xiangjinwu 's invention:

/// A trait that assists code reuse between `validate` and `encode`.
/// * For `validate`, the inputs are (RisingWave type, ProtoBuf type).
/// * For `encode`, the inputs are (RisingWave type, RisingWave data, ProtoBuf type).
///
/// Thus we impl [`MaybeData`] for both [`()`] and [`DatumRef`].
trait MaybeData: std::fmt::Debug {
type Out;
fn on_base(self, f: impl FnOnce(ScalarRefImpl<'_>) -> Result<Value>) -> Result<Self::Out>;
/// Switch to `RecordSchema` after #12562
fn on_struct(self, st: &StructType, avro: &AvroSchema) -> Result<Self::Out>;
fn on_list(self, elem: &DataType, avro: &AvroSchema) -> Result<Self::Out>;
fn handle_union(out: Self::Out, opt_idx: OptIdx) -> Result<Self::Out>;
}

@xxchan xxchan added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 89f93df Sep 19, 2024
30 of 31 checks passed
@xxchan xxchan deleted the 09-13-feat_sink_support_sink_map_type_in_encoder branch September 19, 2024 14:57
github-actions bot pushed a commit that referenced this pull request Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants