-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sink): support sink map to avro #18551
feat(sink): support sink map to avro #18551
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ca90f22
to
80ec46d
Compare
20bc6e2
to
959ac33
Compare
) | ||
); | ||
|
||
let mut inner_map_array_builder = MapArrayBuilder::with_type( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parsing nested map is not supported... so manually construct a test here...
959ac33
to
8f1c089
Compare
Signed-off-by: xxchan <[email protected]>
8f1c089
to
1739576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, What's the purpose of impl MaybeData for ()
?
@xiangjinwu 's invention: risingwave/src/connector/src/sink/encoder/avro.rs Lines 155 to 171 in 97a3293
|
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]> Co-authored-by: xxchan <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.