-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(dashboard): only fetch ids and specified fragments for a relation #18272
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e0d7daf
add new route for fetching table fragments by id
kwannoel 6345700
add fetch for fragments by id
kwannoel f100b73
use useEffect for updating fragmentGraph + introduce fragmentids
kwannoel dda5f8c
update api
kwannoel 10364e3
fix endpoint
kwannoel 185f6c9
use relationIdInfos to search
kwannoel e5a2927
fmt
kwannoel 64a8cca
fix
kwannoel e145467
fix newline
kwannoel 165bdaa
set to undefined while waiting to fetch new graph
kwannoel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -771,3 +771,20 @@ service EventLogService { | |
rpc ListEventLog(ListEventLogRequest) returns (ListEventLogResponse); | ||
rpc AddEventLog(AddEventLogRequest) returns (AddEventLogResponse); | ||
} | ||
|
||
message ActorIds { | ||
repeated uint32 ids = 1; | ||
} | ||
|
||
message FragmentIdToActorIdMap { | ||
map<uint32, ActorIds> map = 1; | ||
} | ||
kwannoel marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/// Provides all the ids: relation_id, fragment_id, actor_id | ||
/// in an hierarchical format. | ||
/// relation_id -> [fragment_id] | ||
/// fragment_id -> [actor_id] | ||
message RelationIdInfos { | ||
// relation_id -> FragmentIdToActorIdMap | ||
map<uint32, FragmentIdToActorIdMap> map = 1; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Provide a new proto for it to make it easier to work with on the web frontend side. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: searchFragId can be used in the comparison so that we save
parseInt
call.