Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dashboard): only fetch ids and specified fragments for a relation #18272

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Aug 27, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously we fetch all fragments across all relations. Then we use it to:

  1. Construct the fragment graph.
  2. Support search by actor id
  3. Support search by fragment id

In this PR we refactor it into:

  1. Only query the required TableFragments for the specified relation_id on demand.
  2. Get a hierarchy of relation_id -> fragment_id -> actor_id, and use this to support search by actor_id, fragment_id.

Part of #18176

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

proto/meta.proto Outdated
message RelationIdInfos {
// relation_id -> FragmentIdToActorIdMap
map<uint32, FragmentIdToActorIdMap> map = 1;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a new proto for it to make it easier to work with on the web frontend side.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proto/meta.proto Show resolved Hide resolved
dashboard/pages/fragment_graph.tsx Show resolved Hide resolved
@kwannoel kwannoel enabled auto-merge August 28, 2024 07:58
@kwannoel kwannoel added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 53c2b0a Aug 28, 2024
32 of 33 checks passed
@kwannoel kwannoel deleted the kwannoel/dag-on-demand branch August 28, 2024 09:00
for (const relationId in map) {
const fragmentIdToRelationId = map[relationId].map
for (const fragmentId in fragmentIdToRelationId) {
if (parseInt(fragmentId) == searchFragIdInt) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: searchFragId can be used in the comparison so that we save parseInt call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants