-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add fast-docker-build-arm
workflow
#18124
Merged
+56
−5
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1205935
add docker no lto
kwannoel 98243e5
set cargo profile
kwannoel 1783f3b
remove profile flag
kwannoel f6c1311
fix
kwannoel 3efcc9c
pass in cargo profile explicitly
kwannoel 79f5288
add profile without incremental build
kwannoel 401c80b
add inherits
kwannoel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ set -euo pipefail | |
ghcraddr="ghcr.io/risingwavelabs/risingwave" | ||
dockerhubaddr="risingwavelabs/risingwave" | ||
arch="$(uname -m)" | ||
CARGO_PROFILE=${CARGO_PROFILE:-production} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It will still default to |
||
|
||
echo "--- ghcr login" | ||
echo "$GHCR_TOKEN" | docker login ghcr.io -u "$GHCR_USERNAME" --password-stdin | ||
|
@@ -23,12 +24,15 @@ fi | |
|
||
# Build RisingWave docker image ${BUILDKITE_COMMIT}-${arch} | ||
echo "--- docker build and tag" | ||
echo "CARGO_PROFILE is set to ${CARGO_PROFILE}" | ||
docker buildx create \ | ||
--name container \ | ||
--driver=docker-container | ||
|
||
docker buildx build -f docker/Dockerfile \ | ||
--build-arg "GIT_SHA=${BUILDKITE_COMMIT}" -t "${ghcraddr}:${BUILDKITE_COMMIT}-${arch}" \ | ||
--build-arg "GIT_SHA=${BUILDKITE_COMMIT}" \ | ||
--build-arg "CARGO_PROFILE=${CARGO_PROFILE}" \ | ||
-t "${ghcraddr}:${BUILDKITE_COMMIT}-${arch}" \ | ||
--progress plain \ | ||
--builder=container \ | ||
--load \ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
auto-retry: &auto-retry | ||
automatic: | ||
# Agent terminated because the AWS EC2 spot instance killed by AWS. | ||
- signal_reason: agent_stop | ||
limit: 3 | ||
|
||
steps: | ||
- label: "docker-build-push: aarch64" | ||
if: build.env("SKIP_TARGET_AARCH64") != "true" | ||
command: "CARGO_PROFILE=patch-production ci/scripts/docker.sh" | ||
key: "build-aarch64" | ||
plugins: | ||
- seek-oss/aws-sm#v2.3.1: | ||
env: | ||
GHCR_USERNAME: ghcr-username | ||
GHCR_TOKEN: ghcr-token | ||
DOCKER_TOKEN: docker-token | ||
GITHUB_TOKEN: github-token | ||
agents: | ||
queue: "linux-arm64" | ||
retry: *auto-retry | ||
|
||
- label: "multi-arch-image-create-push" | ||
command: "SKIP_TARGET_AMD64=true ci/scripts/multi-arch-docker.sh" | ||
depends_on: | ||
- "build-aarch64" | ||
plugins: | ||
- seek-oss/aws-sm#v2.3.1: | ||
env: | ||
GHCR_USERNAME: ghcr-username | ||
GHCR_TOKEN: ghcr-token | ||
DOCKER_TOKEN: docker-token | ||
retry: *auto-retry |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment the reason for other changes: especially
debug
&split-debuginfo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I suppose we don't need those fields. We can just follow what
production
has set. Let me update it.