feat(ci): add fast-docker-build-arm workflow
#18124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
commented
Aug 20, 2024
| @@ -6,6 +6,7 @@ set -euo pipefail | |||
| ghcraddr="ghcr.io/risingwavelabs/risingwave" | |||
| dockerhubaddr="risingwavelabs/risingwave" | |||
| arch="$(uname -m)" | |||
| CARGO_PROFILE=${CARGO_PROFILE:-production} | |||
There was a problem hiding this comment.
It will still default to production, only in the fast docker build we will use release profile.
BugenZhao
approved these changes
Aug 20, 2024
Good idea. Let me see how much further we can bring it down. |
kwannoel
force-pushed
the
kwannoel/docker-no-lto
branch
from
80aff8b to
401c80b
Compare
xxchan
reviewed
Aug 20, 2024
Comment on lines
+301
to
+308
| # Patch profile for production clusters. | ||
| # It will trade-off lto for faster build time. | ||
| [profile.patch-production] | ||
| inherits = "production" | ||
| debug = "full" | ||
| incremental = false | ||
| split-debuginfo = "packed" | ||
| lto = "off" |
There was a problem hiding this comment.
Can you comment the reason for other changes: especially debug & split-debuginfo
There was a problem hiding this comment.
Actually I suppose we don't need those fields. We can just follow what production has set. Let me update it.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Noel Kwan <[email protected]>
kwannoel
added
the
need-cherry-pick-release-1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Thanks to @BugenZhao the work here is rather trivial after #17760.
We just use the
releaseprofile for thefast-docker-build-armworkflow, and only build and tag thearmimage.That profile has
ltodisabled.Bring image build time down to 16m40s. https://buildkite.com/risingwavelabs/fast-docker-build-arm/builds/6#_
Closes #18097
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.