Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(source): use the default_provider for AWS-related connectors #17933

Merged
merged 4 commits into from
Aug 12, 2024
Merged

feat(source): use the default_provider for AWS-related connectors #17933

merged 4 commits into from
Aug 12, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Aug 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See background at #17851

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su
Copy link
Contributor

yuhao-su commented Aug 6, 2024

#11086 We had an issue about this. Do we have a discussion context about why allowing this now?

@fuyufjh
Copy link
Member Author

fuyufjh commented Aug 6, 2024

#11086 We had an issue about this. Do we have a discussion context about why allowing this now?

Yes. See the background https://risingwave-labs.slack.com/archives/C03L8DNMDDW/p1722922448614259?thread_ts=1722281609.938729&cid=C03L8DNMDDW

I feel we might need to review our decision before. Actually many of our (paid) customers tend to use BYOC or even on-prem. This seems to be a reasonable requirement in these cases.

arkbriar
arkbriar reviewed Aug 8, 2024
View reviewed changes
src/connector/src/connector_common/common.rs
@@ -46,6 +46,10 @@ pub const PRIVATE_LINK_TARGETS_KEY: &str = "privatelink.targets";

const AWS_MSK_IAM_AUTH: &str = "AWS_MSK_IAM";

/// The environment variable to disable using default credential from environment.
/// It's recommended to set this variable to `false` in cloud hosting environment.
const DISABLE_DEFAULT_CREDENTIAL: &str = "DISABLE_DEFAULT_CREDENTIAL";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall it affect services from cloud vendors besides AWS as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the idea looks good to you, I'll add the support of Azure/GCP in future PRs. This PR was supposed to complete #17851

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks!

arkbriar
arkbriar approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fuyufjh fuyufjh added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 3707a1e Aug 12, 2024
31 of 32 checks passed
@fuyufjh fuyufjh deleted the 17849-support-aws-creds-kinesis branch August 12, 2024 09:27
@fuyufjh fuyufjh mentioned this pull request Aug 13, 2024
Closed
9 tasks
@tabVersion tabVersion added the need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Aug 16, 2024
github-actions bot pushed a commit that referenced this pull request Aug 16, 2024
@fuyufjh @psheets
feat(source): use the default_provider for AWS-related connectors (#1…
9c0750b 
…7933)

Co-authored-by: Phil Sheets <[email protected]>
Co-authored-by: psheets <[email protected]>
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 16, 2024
@github-actions @fuyufjh @psheets
feat(source): use the default_provider for AWS-related connectors (#1…
f1167ee 
…7933) (#18064)

Co-authored-by: Eric Fu <[email protected]>
Co-authored-by: Phil Sheets <[email protected]>
Co-authored-by: psheets <[email protected]>
@fuyufjh fuyufjh mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabVersion tabVersion tabVersion approved these changes

@arkbriar arkbriar arkbriar approved these changes

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

@yuhao-su yuhao-su Awaiting requested review from yuhao-su

@xxchan xxchan Awaiting requested review from xxchan

Assignees
No one assigned
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fuyufjh @yuhao-su @arkbriar @tabVersion @psheets