Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source): use the default_provider for kinesis (#17849) #17851

Conversation

psheets
Copy link
Contributor

@psheets psheets commented Jul 29, 2024

…ential provider chain

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

17849
Updated Kinesis source to use k8s service accounts.

  • build_credential_provider - updated to changed to async and made it use the default_provider if access_key and secret_key were not provided.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

aws.credentials.access_key_id and aws.credentials.secret_access_key are no longer required for the Kinesis source. Not providing them will make the connector fallback to the aws default_provider.

@psheets psheets changed the title solution for issue 17849, adding default fallback to aws default cred… feat(source): use the default_provider for kinesis (#17849) Jul 29, 2024
@xiangjinwu
Copy link
Contributor

Related: #11086 (Resolved by #11120)

@fuyufjh
Copy link
Member

fuyufjh commented Aug 13, 2024

Hi, @psheets I modified this PR a bit to add an environment variable to disable this function. Opened a new one #17933 because GitHub doesn't allow me to commit on your branch

@fuyufjh fuyufjh closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants