-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: column aware row encoding: improve the implementation and add bench #17818
Merged
+158
−26
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
425e5f5
add benchmark
fuyufjh 8491e6d
improve performance
fuyufjh f12a6b0
use sorted algorithm & add assertion
fuyufjh c8ab9dc
cargo clippy
fuyufjh 98a452d
revert "use sorted algorithm & add assertion"
fuyufjh 3254735
tune performace
fuyufjh 8f62164
bench 4 columns
fuyufjh b76984c
build a default row in advance
fuyufjh f84fc06
Merge branch 'main' into eric/bench_column_aware_encoding
fuyufjh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build a default row in advance
commit b76984c7d5491feedfe0ebb652fba12fe43b5ab7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. I thought
BTreeMap
is faster when there are only a few entries: https://arc.net/l/quote/okdycbqiThe current value of
B
is 6. According to this, can we also benchmark the case for a table containing less than 6 columns?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added bench
column_aware_row_encoding_4_columns
. Observed a similar performance improvement.