refactor: graceful shutdown in standalone mode #17633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
BugenZhao
force-pushed
the
bz/07-09-standalone_graceful_shutdown
branch
from
8338456 to
9ffcdd8
Compare
BugenZhao
changed the base branch from
bz/shutdown-meta-1
to
bz/risedev-run-command
BugenZhao
force-pushed
the
bz/risedev-run-command
branch
from
6ec81c2 to
05e2ce9
Compare
BugenZhao
force-pushed
the
bz/07-09-standalone_graceful_shutdown
branch
from
9ffcdd8 to
cba41b4
Compare
BugenZhao
force-pushed
the
bz/risedev-run-command
branch
from
05e2ce9 to
6660205
Compare
BugenZhao
force-pushed
the
bz/07-09-standalone_graceful_shutdown
branch
from
cba41b4 to
739d0ea
Compare
BugenZhao
force-pushed
the
bz/risedev-run-command
branch
from
6660205 to
ac9be58
Compare
BugenZhao
force-pushed
the
bz/07-09-standalone_graceful_shutdown
branch
2 times, most recently
from
8ad50ea to
c2f61ba
Compare
4 tasks
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/07-09-standalone_graceful_shutdown
branch
from
3142219 to
d9a8caf
Compare
kwannoel
reviewed
Jul 15, 2024
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
kwannoel
approved these changes
Jul 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Follow-up of #17533, based on the ideas proposed in #17351 (comment).
Support graceful shutdown for standalone (single-node, playground) mode.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.