fix(risedev): fixes and improvements for risedev-dev running risingwave commands
#17586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
BugenZhao
commented
Jul 5, 2024
| @@ -138,11 +138,7 @@ where | |||
| if !id.is_empty() { | |||
| self.pb.set_prefix(id.clone()); | |||
| self.id = Some(id.clone()); | |||
|
|
|||
| // Remove the old status file if exists to avoid confusion. | |||
| let status_file = self.status_dir.path().join(format!("{}.status", id)); | |||
There was a problem hiding this comment.
status_dir is a temp dir. It cannot be the identical to the one in previous run.
Can't merge now as it essentially make Requires all tasks of #17351 to be done. |
BugenZhao
force-pushed
the
bz/risedev-run-command
branch
from
c632be0 to
cf27a65
Compare
4 tasks
BugenZhao
force-pushed
the
bz/shutdown-meta-1
branch
from
3d20d6b to
869dfcb
Compare
BugenZhao
force-pushed
the
bz/risedev-run-command
branch
from
cf27a65 to
6c07313
Compare
BugenZhao
force-pushed
the
bz/shutdown-meta-1
branch
from
869dfcb to
a466fce
Compare
4 tasks
BugenZhao
force-pushed
the
bz/risedev-run-command
branch
2 times, most recently
from
6ec81c2 to
05e2ce9
Compare
BugenZhao
force-pushed
the
bz/shutdown-meta-1
branch
from
955a90d to
8de79d9
Compare
BugenZhao
force-pushed
the
bz/risedev-run-command
branch
from
05e2ce9 to
6660205
Compare
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/risedev-run-command
branch
from
6660205 to
ac9be58
Compare
Signed-off-by: Bugen Zhao <[email protected]>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Several fixes and improvements for
risedev-devrunning risingwave commands.Let risingwave processes handle Ctrl-C and run shutdown logic, instead of signaling
teewhich kills risingwave abnormally.Keep colors when checking logs in
tmuxwindows.Ignore writing to the status file if it is not present, which is normal when
risedev-devsuccessfully finishes launching all components and the temporary status file is cleaned up.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.