Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support format plain encode avro for kafka #17216

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Jun 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

A missing piece from #13007. The refactor was done by #16575.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

For kafka, format plain encode avro is supported in addition to previously supported format upsert encode avro.

@stdrc stdrc self-requested a review June 12, 2024 07:49
@xiangjinwu xiangjinwu force-pushed the feat-sink-plain-avro branch from ce79e72 to 021cc91 Compare June 13, 2024 13:43

This comment was marked as off-topic.

@xiangjinwu xiangjinwu marked this pull request as ready for review June 13, 2024 13:44
@xiangjinwu xiangjinwu requested review from tabVersion and xxchan June 13, 2024 14:24
@xiangjinwu xiangjinwu added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit ac7abd9 Jun 14, 2024
29 of 31 checks passed
@xiangjinwu xiangjinwu deleted the feat-sink-plain-avro branch June 14, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants