Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector): add benchmark for parsing combined (struct type) nexmark events #17189

Merged
merged 2 commits into from
Jun 11, 2024
Merged

test(connector): add benchmark for parsing combined (struct type) nexmark events #17189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bbb5a4
test(connector): add benchmark for parsing combined (struct-field) ne…
BugenZhao Jun 10, 2024
1f8c751
revert cargo toml change
BugenZhao Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 54 additions & 24 deletions src/connector/benches/nexmark_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use criterion::{criterion_group, criterion_main, BatchSize, Criterion};
use futures::{FutureExt, StreamExt, TryStreamExt};
use itertools::Itertools;
use risingwave_common::array::StreamChunk;
use risingwave_common::catalog::ColumnId;
use risingwave_common::catalog::{ColumnDesc, ColumnId};
use risingwave_common::types::DataType;
use risingwave_connector::parser::{
ByteStreamSourceParserImpl, CommonParserConfig, ParserConfig, SpecificParserConfig,
Expand All @@ -37,15 +37,12 @@ use risingwave_connector::source::{
use tracing::Level;
use tracing_subscriber::prelude::*;

static BATCH: LazyLock<Vec<SourceMessage>> = LazyLock::new(make_batch);
static BATCH: LazyLock<Vec<SourceMessage>> = LazyLock::new(|| make_batch(false));
static STRUCT_BATCH: LazyLock<Vec<SourceMessage>> = LazyLock::new(|| make_batch(true));

fn make_batch() -> Vec<SourceMessage> {
fn make_batch(use_struct: bool) -> Vec<SourceMessage> {
let mut generator = nexmark::EventGenerator::default()
.with_type_filter(nexmark::event::EventType::Bid)
.map(|e| match e {
nexmark::event::Event::Bid(bid) => bid, // extract the bid event
_ => unreachable!(),
})
.enumerate();

let message_base = SourceMessage {
Expand All @@ -59,8 +56,15 @@ fn make_batch() -> Vec<SourceMessage> {
generator
.by_ref()
.take(16384)
.map(|(i, e)| {
let payload = serde_json::to_vec(&e).unwrap();
.map(|(i, event)| {
let payload = if use_struct {
serde_json::to_vec(&event).unwrap()
} else {
let nexmark::event::Event::Bid(bid) = event else {
unreachable!()
};
serde_json::to_vec(&bid).unwrap()
};
SourceMessage {
payload: Some(payload),
offset: i.to_string(),
Expand All @@ -70,26 +74,42 @@ fn make_batch() -> Vec<SourceMessage> {
.collect_vec()
}

fn make_data_stream() -> BoxSourceStream {
futures::future::ready(Ok(BATCH.clone()))
.into_stream()
.boxed()
fn make_data_stream(use_struct: bool) -> BoxSourceStream {
futures::future::ready(Ok(if use_struct {
STRUCT_BATCH.clone()
} else {
BATCH.clone()
}))
.into_stream()
.boxed()
}

fn make_parser() -> ByteStreamSourceParserImpl {
let rw_columns = [
fn make_parser(use_struct: bool) -> ByteStreamSourceParserImpl {
let fields = vec![
("auction", DataType::Int64),
("bidder", DataType::Int64),
("price", DataType::Int64),
("channel", DataType::Varchar),
("url", DataType::Varchar),
("date_time", DataType::Timestamp),
("extra", DataType::Varchar),
]
.into_iter()
.enumerate()
.map(|(i, (n, t))| SourceColumnDesc::simple(n, t, ColumnId::new(i as _)))
.collect_vec();
];

let rw_columns = if use_struct {
let fields = fields
.into_iter()
.enumerate()
.map(|(i, (n, t))| ColumnDesc::named(n, ColumnId::new(i as _), t))
.collect();
let struct_col = ColumnDesc::new_struct("bid", 114514, "bid", fields);
vec![(&struct_col).into()]
} else {
fields
.into_iter()
.enumerate()
.map(|(i, (n, t))| SourceColumnDesc::simple(n, t, ColumnId::new(i as _)))
.collect_vec()
};

let config = ParserConfig {
common: CommonParserConfig { rw_columns },
Expand All @@ -99,8 +119,10 @@ fn make_parser() -> ByteStreamSourceParserImpl {
ByteStreamSourceParserImpl::create_for_test(config).unwrap()
}

fn make_stream_iter() -> impl Iterator<Item = StreamChunk> {
let mut stream: BoxChunkSourceStream = make_parser().into_stream(make_data_stream()).boxed();
fn make_stream_iter(use_struct: bool) -> impl Iterator<Item = StreamChunk> {
let mut stream: BoxChunkSourceStream = make_parser(use_struct)
.into_stream(make_data_stream(use_struct))
.boxed();

std::iter::from_fn(move || {
stream
Expand All @@ -116,7 +138,7 @@ fn make_stream_iter() -> impl Iterator<Item = StreamChunk> {
fn bench(c: &mut Criterion) {
c.bench_function("parse_nexmark", |b| {
b.iter_batched(
make_stream_iter,
|| make_stream_iter(false),
|mut iter| iter.next().unwrap(),
BatchSize::SmallInput,
)
Expand All @@ -135,11 +157,19 @@ fn bench(c: &mut Criterion) {
.into();

b.iter_batched(
make_stream_iter,
|| make_stream_iter(false),
|mut iter| tracing::dispatcher::with_default(&dispatch, || iter.next().unwrap()),
BatchSize::SmallInput,
)
});

c.bench_function("parse_nexmark_struct_type", |b| {
b.iter_batched(
|| make_stream_iter(true),
|mut iter| iter.next().unwrap(),
BatchSize::SmallInput,
)
});
}

criterion_group!(benches, bench);
Expand Down
Loading