Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector): add benchmark for parsing combined (struct type) nexmark events #17189

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jun 10, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add a new benchmark function in nexmark_integration.rs that takes combined events as input, where each event is represented with a single composed struct field.

This covers the real path of our nexmark benchmark, as described in #17153 (comment).

Here's a snapshot of the current performance (with LTO off):

parse_nexmark           time:   [19.251 ms 19.297 ms 19.348 ms]

parse_nexmark_with_tracing
                        time:   [19.268 ms 19.342 ms 19.426 ms]

parse_nexmark_struct_type
                        time:   [28.135 ms 28.340 ms 28.547 ms]

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

BugenZhao commented Jun 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BugenZhao and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the component/test Test related issue. label Jun 10, 2024
@BugenZhao BugenZhao changed the title test(connector): add benchmark for parsing combined (struct-field) nexmark events test(connector): add benchmark for parsing combined (struct type) nexmark events Jun 10, 2024
@BugenZhao BugenZhao force-pushed the bz/nexmark-struct-parse-bench branch from d11dab9 to 1f8c751 Compare June 10, 2024 09:27
@BugenZhao BugenZhao changed the base branch from bz/parser-perf-2.5 to main June 10, 2024 09:27
@BugenZhao BugenZhao requested review from stdrc and xxchan June 10, 2024 09:39
@BugenZhao BugenZhao added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 1424788 Jun 11, 2024
30 of 31 checks passed
@BugenZhao BugenZhao deleted the bz/nexmark-struct-parse-bench branch June 11, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants