refactor(connector): migrate to zero-copy access implementation #17165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
4 tasks
BugenZhao
force-pushed
the
bz/parser-perf-3
branch
2 times, most recently
from
6c011d7 to
1ad1b1f
Compare
This was referenced Jun 7, 2024
BugenZhao
changed the title
BugenZhao
force-pushed
the
bz/parser-perf-3
branch
from
1ad1b1f to
d21f36b
Compare
xxchan
approved these changes
Jun 10, 2024
Comment on lines
59
to
62
| /// Similar to `access`, but may return a borrowed [`DatumCow::Borrowed`] to avoid unnecessary allocation. | ||
| /// If not overridden, it will call forward to `access` and always wrap the result in [`DatumCow::Owned`]. | ||
| /// | ||
| /// This should be preferred over `access` for both callers and implementors. |
There was a problem hiding this comment.
The doc comment needs to be fixed. It's mixed together with above.
There was a problem hiding this comment.
It is likely due to resolving merge conflicts. Will fix.
BugenZhao
commented
Jun 10, 2024
| @@ -312,7 +308,10 @@ where | |||
| Err(create_error())?; | |||
| } | |||
|
|
|||
| options.convert_to_datum(value, type_expected) | |||
| // TODO: may borrow the value directly | |||
There was a problem hiding this comment.
Will address in #17171.
Comment on lines
59
to
62
| /// Similar to `access`, but may return a borrowed [`DatumCow::Borrowed`] to avoid unnecessary allocation. | ||
| /// If not overridden, it will call forward to `access` and always wrap the result in [`DatumCow::Owned`]. | ||
| /// | ||
| /// This should be preferred over `access` for both callers and implementors. |
There was a problem hiding this comment.
It is likely due to resolving merge conflicts. Will fix.
BugenZhao
force-pushed
the
bz/parser-perf-3
branch
from
e80f0eb to
3c059d5
Compare
BugenZhao
force-pushed
the
bz/parser-perf-2
branch
from
d6b28be to
a05c149
Compare
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/parser-perf-3
branch
from
3c059d5 to
53177c7
Compare
Merge activity
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Follow-up of #17153.
access_cowin all implementors ofAccess.access_coweverywhere if possible.access_cowtoaccessand make it the only method that need/can be implemented in the trait.accesstoaccess_ownedto implicitly show the intention of requiring an owned datum in the callsite. Make it an extension trait, so that it cannot be overridden.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.