Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): trigger uploader sync on SyncEpoch event #17113

Merged
merged 16 commits into from
Jun 6, 2024
Merged

refactor(storage): trigger uploader sync on SyncEpoch event #17113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5bf7d5e
refactor(storage): add metrics for uploader memory and refactor uploa…
wenym1 Jun 3, 2024
c4dae2a
Merge branch 'main' into yiming/imm-no-instance-id
wenym1 Jun 3, 2024
9ddb77f
impl uploader imm
wenym1 Jun 3, 2024
ce4c773
Merge branch 'main' into yiming/imm-no-instance-id
wenym1 Jun 4, 2024
761f42b
refactor(storage): emit all sst in uploader sync finish event
wenym1 Jun 4, 2024
d938bd4
include result sender in syncing data
wenym1 Jun 4, 2024
348f7c9
Merge branch 'main' into yiming/imm-no-instance-id
wenym1 Jun 5, 2024
37371d8
Merge branch 'yiming/imm-no-instance-id' into yiming/new-sync-finish-…
wenym1 Jun 5, 2024
a66298a
Merge branch 'main' into yiming/imm-no-instance-id
wenym1 Jun 5, 2024
bd08040
Merge branch 'yiming/imm-no-instance-id' into yiming/new-sync-finish-…
wenym1 Jun 5, 2024
19d34c4
address comment
wenym1 Jun 5, 2024
7392b8b
fix sync order
wenym1 Jun 5, 2024
9205ec8
add unit test
wenym1 Jun 5, 2024
793e6d5
Merge branch 'main' into yiming/new-sync-finish-event
wenym1 Jun 5, 2024
9e69c2c
temp revert to main
wenym1 Jun 5, 2024
862793f
Revert "temp revert to main"
wenym1 Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
353 changes: 189 additions & 164 deletions src/storage/src/hummock/event_handler/hummock_event_handler.rs
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/storage/src/hummock/event_handler/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ pub enum HummockEvent {
/// An epoch is going to be synced. Once the event is processed, there will be no more flush
/// task on this epoch. Previous concurrent flush task join handle will be returned by the join
/// handle sender.
AwaitSyncEpoch {
SyncEpoch {
new_sync_epoch: HummockEpoch,
sync_result_sender: oneshot::Sender<HummockResult<SyncResult>>,
},
Expand Down Expand Up @@ -107,7 +107,7 @@ impl HummockEvent {
match self {
HummockEvent::BufferMayFlush => "BufferMayFlush".to_string(),

HummockEvent::AwaitSyncEpoch {
HummockEvent::SyncEpoch {
new_sync_epoch,
sync_result_sender: _,
} => format!("AwaitSyncEpoch epoch {} ", new_sync_epoch),
Expand Down
Loading
Loading