refactor(storage): trigger uploader sync on SyncEpoch event #17113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenym1
changed the title
hzxa21
approved these changes
Jun 5, 2024
| for (_, unsealed_data) in self.unsealed_data { | ||
| unsealed_data.spilled_data.abort(); | ||
| } | ||
| for syncing_data in self.syncing_data { |
There was a problem hiding this comment.
Do we need to abort the uploading task in syncing_data as well?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This reverts commit 9e69c2c.
wenym1
added a commit
that referenced
this pull request
Jun 19, 2024
hzxa21
pushed a commit
that referenced
this pull request
Jun 21, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #17111
Previously when sync fails, the uploader will continue working, and the later spilled sst may break the imm order sanity check and panics. In this PR we will pause the work of uploader when sync fails, and wait for a recovery event to clear and restart the uploader.
Besides, previously the sync notifiers are stored in event handler and synced data are stored in uploader, and on the
SyncFinishevent, event handler get the synced data from uploader and then notify sync result. In this PR, we change to store the sync notifier in uploader, and when sync finish, before emitting the event, uploader will notify the sync result internally, and there is no need to store synced data any more.The newly added unit test can reproduce the same panics in #17111.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.