-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support schema registry in risedev #17001
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,8 +27,8 @@ use risedev::{ | |
generate_risedev_env, preflight_check, CompactorService, ComputeNodeService, ConfigExpander, | ||
ConfigureTmuxTask, DummyService, EnsureStopService, ExecuteContext, FrontendService, | ||
GrafanaService, KafkaService, MetaNodeService, MinioService, MySqlService, PostgresService, | ||
PrometheusService, PubsubService, RedisService, ServiceConfig, SqliteConfig, Task, | ||
TempoService, RISEDEV_NAME, | ||
PrometheusService, PubsubService, RedisService, SchemaRegistryService, ServiceConfig, | ||
SqliteConfig, Task, TempoService, RISEDEV_NAME, | ||
}; | ||
use tempfile::tempdir; | ||
use thiserror_ext::AsReport; | ||
|
@@ -279,6 +279,18 @@ fn task_main( | |
ctx.pb | ||
.set_message(format!("kafka {}:{}", c.address, c.port)); | ||
} | ||
ServiceConfig::SchemaRegistry(c) => { | ||
let mut ctx = | ||
ExecuteContext::new(&mut logger, manager.new_progress(), status_dir.clone()); | ||
let mut service = SchemaRegistryService::new(c.clone()); | ||
service.execute(&mut ctx)?; | ||
let mut task = | ||
risedev::TcpReadyCheckTask::new(c.address.clone(), c.port, c.user_managed)?; | ||
Comment on lines
+287
to
+288
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you checked whether this is accurate? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How can I check? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe perform a GET request and check the code equals to 200. Here's an example
|
||
task.execute(&mut ctx)?; | ||
ctx.pb | ||
.set_message(format!("schema registry http://{}:{}", c.address, c.port)); | ||
} | ||
|
||
ServiceConfig::Pubsub(c) => { | ||
let mut ctx = | ||
ExecuteContext::new(&mut logger, manager.new_progress(), status_dir.clone()); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listen-address is unused